vlsi commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r762006519
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Project.java
##########
@@ -70,17 +71,21 @@
protected final ImmutableList<RelHint> hints;
+ protected final ImmutableSet<CorrelationId> variablesSet;
+
//~ Constructors -----------------------------------------------------------
/**
* Creates a Project.
*
- * @param cluster Cluster that this relational expression belongs to
- * @param traits Traits of this relational expression
- * @param hints Hints of this relation expression
- * @param input Input relational expression
- * @param projects List of expressions for the input columns
- * @param rowType Output row type
+ * @param cluster Cluster that this relational expression belongs to
+ * @param traits Traits of this relational expression
+ * @param hints Hints of this relation expression
+ * @param input Input relational expression
+ * @param projects List of expressions for the input columns
+ * @param rowType Output row type
Review comment:
Frankly speaking, I think we should avoid reflowing the comments.
There's no point in changing all the previous lines when you add a new one.
See
https://google.github.io/styleguide/javaguide.html#s4.6.3-horizontal-alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
