jacques-n commented on pull request #2639:
URL: https://github.com/apache/calcite/pull/2639#issuecomment-991311116
> You could just have it throw an exception since the value is never
actually needed.
That would be a breaking change (downstream projects may be using
`getDef()`). We should deprecate for at least one release before removing
and/or throwing. This means for at least one release (possibly many), the PR
alleviates downstream boilerplate implementations and allows most handlers to
be functional. It also allows implementers to be less impacted once the method
deprecates and then is removed.
While getDef() deprecation may make sense ultimately, I'd like to see any
patch that proposes that to also modify `ReflectiveRelMetadataProvider` to
avoid it's use in the non-deprecated path of `public static <M extends
Metadata> RelMetadataProvider reflectiveSource(
MetadataHandler<? extends M>, Class<? extends MetadataHandler<M>>)`.
This seems beyond the scope of this change. Happy to review that patch
separately if you'd like to propose it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
