jacques-n commented on pull request #2639: URL: https://github.com/apache/calcite/pull/2639#issuecomment-991723967
@jamesstarr, you're right that technically it wouldn't be a breaking change. However, it doesn't seem like a good approach since it is a misleading change. Having getDef() throw and marking the subinterfaces as functional means you have a suggested interface that doesn't actually work in the reflective provider. The change here avoids causing that unexpected/misleading behavior. As I said, if you want to get rid of the method moving forward, I'm fully supportive of doing that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
