jamesstarr commented on pull request #2639: URL: https://github.com/apache/calcite/pull/2639#issuecomment-991484772
All of calcites instances would still return value, and previously all of their instances would have had to have an implementation. You can not break down stream code by adding a default implementation, after wall it was one of the design goals of java 8. On Fri, Dec 10, 2021 at 1:35 PM Jacques Nadeau ***@***.***> wrote: > You could just have it throw an exception since the value is never > actually needed. > > That would be a breaking change (downstream projects may be using getDef()). > We should deprecate for at least one release before removing and/or > throwing. This means for at least one release (possibly many), the PR > alleviates downstream boilerplate implementations and allows most handlers > to be functional. It also allows implementers to be less impacted once the > method deprecates and then is removed. > > While getDef() deprecation may make sense ultimately, I'd like to see any > patch that proposes that to also modify ReflectiveRelMetadataProvider to > avoid it's use in the non-deprecated path of public static <M extends > Metadata> RelMetadataProvider reflectiveSource( MetadataHandler<? extends > M>, Class<? extends MetadataHandler<M>>). This seems beyond the scope of > this change. Happy to review that patch separately if you'd like to propose > it. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/calcite/pull/2639#issuecomment-991311116>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAMO4UPALVTQSJBXA3MBSBLUQJXCLANCNFSM5JXXFVVA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
