asolimando commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1166633062
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -3288,6 +3288,57 @@ private void checkSarg(String message, Sarg sarg,
not(rexBuilder.makeCall(SqlStdOperatorTable.SIMILAR_TO, ref,
literal("%"))));
}
+ @Test void testSimplifyNullCheckInFilter() {
Review Comment:
Can we split the test into multiple tests?
Upon failure it should be clear what went wrong, by bundling all in one test
it's harder to tell.
This said, I understand that it will repeat the first part but I still think
it's a price worth paying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
