asolimando commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1166688302
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -3288,6 +3288,57 @@ private void checkSarg(String message, Sarg sarg,
not(rexBuilder.makeCall(SqlStdOperatorTable.SIMILAR_TO, ref,
literal("%"))));
}
+ @Test void testSimplifyNullCheckInFilter() {
Review Comment:
AFAIK we don't have strong guidelines around this, we mostly act as you did,
we look at existing code and we try to adapt to it.
Concerning the two conflicting styles, I see that older tests (> 5 years
ago) are more inclined to put lots of cases inside a single test, newer code
seems to be more for "single case - single test", which might be a bit more
verbose for the "data preparation", but makes tests more readable and
debuggable IMO.
I don't feel strongly about this but I favour the "newer" style. If nobody
else chimes in and you prefer the current organization I won't object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
