asolimando commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1166643387
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -1793,16 +1761,51 @@ private <C extends Comparable<C>> RexNode
simplifyAnd2ForUnknownAsFalse(
return rexBuilder.makeLiteral(false);
}
}
- // Add the NOT disjunctions back in.
- for (RexNode notDisjunction : notTerms) {
- terms.add(not(notDisjunction));
- }
// The negated terms: only deterministic expressions
for (RexNode negatedTerm : negatedTerms) {
if (termsSet.contains(negatedTerm)) {
return rexBuilder.makeLiteral(false);
}
}
+ // Add the NOT disjunctions back in.
Review Comment:
Just for my understanding, why you decided to move this part after the for
loop above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
