JiajunBernoulli commented on code in PR #3225:
URL: https://github.com/apache/calcite/pull/3225#discussion_r1208220206
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7089,7 +7105,18 @@ Sql withMysql8() {
}
Sql withOracle() {
- return dialect(DatabaseProduct.ORACLE.getDialect());
+ return withOracle(12);
+ }
+
+ Sql withOracle(int majorVersion) {
+ final SqlDialect oracleDialect = DatabaseProduct.ORACLE.getDialect();
+ return dialect(
+ new OracleSqlDialect(OracleSqlDialect.DEFAULT_CONTEXT
+ .withDatabaseProduct(DatabaseProduct.ORACLE)
+ .withDatabaseMajorVersion(majorVersion)
+ .withIdentifierQuoteString(oracleDialect.quoteIdentifier("")
Review Comment:
Why need `withIdentifierQuoteString` and `withNullCollation`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
