ILuffZhe commented on code in PR #3225:
URL: https://github.com/apache/calcite/pull/3225#discussion_r1208245225
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7089,7 +7105,18 @@ Sql withMysql8() {
}
Sql withOracle() {
- return dialect(DatabaseProduct.ORACLE.getDialect());
+ return withOracle(12);
+ }
+
+ Sql withOracle(int majorVersion) {
+ final SqlDialect oracleDialect = DatabaseProduct.ORACLE.getDialect();
+ return dialect(
+ new OracleSqlDialect(OracleSqlDialect.DEFAULT_CONTEXT
+ .withDatabaseProduct(DatabaseProduct.ORACLE)
+ .withDatabaseMajorVersion(majorVersion)
+ .withIdentifierQuoteString(oracleDialect.quoteIdentifier("")
Review Comment:
In this case, we don't need those two configuration. But I'm wandering if
they might be reused in the future cases? And I also see that both `withMssql`
and `withMysql8` do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
