JiajunBernoulli commented on code in PR #3225:
URL: https://github.com/apache/calcite/pull/3225#discussion_r1208253390
##########
core/src/main/java/org/apache/calcite/sql/dialect/OracleSqlDialect.java:
##########
@@ -188,4 +191,13 @@ public OracleSqlDialect(Context context) {
}
}
}
+
+ @Override public void unparseOffsetFetch(SqlWriter writer, @Nullable SqlNode
offset,
+ @Nullable SqlNode fetch) {
+ // majorVersion in SqlDialect.EMPTY_CONTEXT is -1 by default
+ if (this.majorVersion != -1 && this.majorVersion < 12) {
+ throw new RuntimeException("Lower Oracle version(<12) doesn't support
offset/fetch syntax!");
+ }
+ unparseFetchUsingAnsi(writer, offset, fetch);
Review Comment:
`super.unparseOffsetFetch(writer, offset, fetch))` is better for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
