JiajunBernoulli commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372495642
##########
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##########
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+ /**
+ * Operand type-checking strategy for a MAP function, it allows empty map.
+ */
+ private static class MapFunctionOperandTypeChecker
+ extends SameOperandTypeChecker {
+
+ MapFunctionOperandTypeChecker() {
+ super(-1);
+ }
+
+ @Override public boolean checkOperandTypes(final SqlCallBinding
callBinding,
+ final boolean throwOnFailure) {
+ final List<RelDataType> argTypes =
+ SqlTypeUtil.deriveType(callBinding, callBinding.operands());
+ // allows empty map
+ if (argTypes.size() == 0) {
+ return true;
+ }
+ // the size of map arg types must be even.
+ if (argTypes.size() % 2 > 0) {
+ throw
callBinding.newValidationError(RESOURCE.mapRequiresEvenArgCount());
+ }
+ final Pair<@Nullable RelDataType, @Nullable RelDataType> componentType =
+ getComponentTypes(
+ callBinding.getTypeFactory(), argTypes);
+ // check key type & value type
+ if (null == componentType.left || null == componentType.right) {
+ if (throwOnFailure) {
+ throw
callBinding.newValidationError(RESOURCE.needSameTypeParameter());
+ }
+ return false;
+ }
+ return true;
+ }
+
+ /**
+ * Extract the key type and value type of arg types.
+ */
+ private static Pair<@Nullable RelDataType, @Nullable RelDataType>
getComponentTypes(
+ RelDataTypeFactory typeFactory,
+ List<RelDataType> argTypes) {
+ return Pair.of(
+ typeFactory.leastRestrictive(Util.quotientList(argTypes, 2, 0)),
Review Comment:
Can we add UT for `typeFactory.leastRestrictive`?
How about?
`MAP('k1', 1, 'k2', 2.0, 'k3', '3')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
