julianhyde commented on code in PR #3506:
URL: https://github.com/apache/calcite/pull/3506#discussion_r1384199193
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeUnionRule.java:
##########
@@ -125,6 +125,7 @@ public EnumerableMergeUnionRule(Config config) {
RexNode node = fields.get(i);
if (fieldsRequiringCast.get(i)) {
final RelDataType targetType = unionFieldList.get(i).getType();
+ // TODO: can this cast fail?
Review Comment:
Don't add a TODO. Either do it or log a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
