julianhyde commented on code in PR #3506:
URL: https://github.com/apache/calcite/pull/3506#discussion_r1384199791
##########
core/src/main/java/org/apache/calcite/rel/core/AggregateCall.java:
##########
@@ -129,58 +111,8 @@ private AggregateCall(SqlAggFunction aggFunction, boolean
distinct,
//~ Methods ----------------------------------------------------------------
- @Deprecated // to be removed before 2.0
- public static AggregateCall create(SqlAggFunction aggFunction,
- boolean distinct, List<Integer> argList, int groupCount, RelNode input,
- @Nullable RelDataType type, @Nullable String name) {
- return create(aggFunction, distinct, false, false,
- ImmutableList.of(), argList, -1,
- null, RelCollations.EMPTY, groupCount, input, type, name);
- }
-
- @Deprecated // to be removed before 2.0
- public static AggregateCall create(SqlAggFunction aggFunction,
- boolean distinct, List<Integer> argList, int filterArg, int groupCount,
- RelNode input, @Nullable RelDataType type, @Nullable String name) {
- return create(aggFunction, distinct, false, false,
- ImmutableList.of(), argList, filterArg,
- null, RelCollations.EMPTY, groupCount, input, type, name);
- }
-
- @Deprecated // to be removed before 2.0
- public static AggregateCall create(SqlAggFunction aggFunction,
- boolean distinct, boolean approximate, List<Integer> argList,
- int filterArg, int groupCount,
- RelNode input, @Nullable RelDataType type, @Nullable String name) {
- return create(aggFunction, distinct, approximate, false,
- ImmutableList.of(), argList,
- filterArg, null, RelCollations.EMPTY, groupCount, input, type, name);
- }
-
- @Deprecated // to be removed before 2.0
- public static AggregateCall create(SqlAggFunction aggFunction,
- boolean distinct, boolean approximate, List<Integer> argList,
- int filterArg, RelCollation collation, int groupCount,
- RelNode input, @Nullable RelDataType type, @Nullable String name) {
- return create(aggFunction, distinct, approximate, false,
- ImmutableList.of(), argList, filterArg,
- null, collation, groupCount, input, type, name);
- }
-
- @Deprecated // to be removed before 2.0
- public static AggregateCall create(SqlAggFunction aggFunction,
- boolean distinct, boolean approximate, boolean ignoreNulls,
- List<Integer> argList, int filterArg,
- @Nullable ImmutableBitSet distinctKeys, RelCollation collation,
- int groupCount,
- RelNode input, @Nullable RelDataType type, @Nullable String name) {
- return create(aggFunction, distinct, approximate, ignoreNulls,
- ImmutableList.of(), argList, filterArg,
- distinctKeys, collation, groupCount, input, type, name);
- }
-
Review Comment:
Sorry, we can't remove deprecated stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
