tanclary commented on code in PR #3596:
URL: https://github.com/apache/calcite/pull/3596#discussion_r1435824190
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12376,6 +12376,9 @@ void testTimestampDiff(boolean coercionEnabled) {
f.checkScalar("FORMAT_DATE('The date is: %x', DATE '2008-12-25')",
"The date is: 12/25/08",
"VARCHAR(2000) NOT NULL");
+ f.checkNull("FORMAT_DATE('%x', CAST(NULL AS DATE))");
Review Comment:
If there aren't tests where the format itself is null we should add some of
those as well while we're at it/
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12439,6 +12442,9 @@ void testTimestampDiff(boolean coercionEnabled) {
f.checkScalar("PARSE_DATE('%F', '2022-06-01')",
"2022-06-01",
"DATE NOT NULL");
+ f.checkNull("PARSE_DATE('%F', CAST(NULL AS DATE))");
Review Comment:
same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
