caicancai commented on code in PR #3596:
URL: https://github.com/apache/calcite/pull/3596#discussion_r1435830287
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12376,6 +12376,9 @@ void testTimestampDiff(boolean coercionEnabled) {
f.checkScalar("FORMAT_DATE('The date is: %x', DATE '2008-12-25')",
"The date is: 12/25/08",
"VARCHAR(2000) NOT NULL");
+ f.checkNull("FORMAT_DATE('%x', CAST(NULL AS DATE))");
Review Comment:
Hello, thank you for your review
```java
f.checkNull("FORMAT_DATE(NULL, DATE '2008-12-25'");
```
This way of writing shows parser error. Do I need to add comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
