tanclary commented on code in PR #3596:
URL: https://github.com/apache/calcite/pull/3596#discussion_r1435830439
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12376,6 +12376,9 @@ void testTimestampDiff(boolean coercionEnabled) {
f.checkScalar("FORMAT_DATE('The date is: %x', DATE '2008-12-25')",
"The date is: 12/25/08",
"VARCHAR(2000) NOT NULL");
+ f.checkNull("FORMAT_DATE('%x', CAST(NULL AS DATE))");
Review Comment:
It depends what the anticipated behavior is. If a parser error is expected
then that makes sense. If we expect a `null` result then something is wrong. Do
you know what the expected behavior should be if a null format is passed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
