rorueda commented on code in PR #3653:
URL: https://github.com/apache/calcite/pull/3653#discussion_r1471071836
##########
core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java:
##########
@@ -77,8 +80,26 @@ class FormatElementEnumTest {
assertFormatElement(FormatElementEnum.FF6, "2014-09-30T10:00:00.123456Z",
"000123");
}
- @Test void testIW() {
- assertFormatElement(FormatElementEnum.IW, "2014-09-30T10:00:00Z", "40");
+ @Test void testID() {
+ assertFormatElement(FormatElementEnum.ID, "2014-09-30T10:00:00Z", "2");
+ }
Review Comment:
As there is one method for each format element, I didn't want to add new
methods to test the edge cases of ISOWEEK and ISOYEAR, and I thought a good
solution was to make those tests parameterized.
But I agree that the way it was done didn't help in making the added test
cases understandable. I removed the parameters and made more assertions inside
the method (with a comment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
