tanclary commented on code in PR #3674:
URL: https://github.com/apache/calcite/pull/3674#discussion_r1482010981


##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableBatchNestedLoopJoin.java:
##########
@@ -124,8 +124,8 @@ public static EnumerableBatchNestedLoopJoin create(
       final RelMetadataQuery mq) {
     double rowCount = mq.getRowCount(this);
 
-    final double rightRowCount = right.estimateRowCount(mq);

Review Comment:
   Can we please write a test for this? If it shouldn't be used then a test 
would be helpful to show why, and how this commit corrects that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to