rubenada commented on PR #3674: URL: https://github.com/apache/calcite/pull/3674#issuecomment-1948175530
I understand your point of view and I appreciate your comments @tanclary , and I also appreciate the fact that your intention is not to block this. In principle, I agree with you: generally speaking, we should not accept PRs without tests, especially for bugs. Perhaps this issue should have been filed as an improvement/task rather than a bug (there is no error or exception in the current code, just a lack of pluggability), so it might be open to interpretation. As I said before, exceptionally, I think we can merge the current PR as it is. Since we have 3 committers who have approved/LGTM'ed, and no explicit veto or -1; I propose to merge the PR, if no further comment (or veto) appears in the next 48h. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
