kramerul commented on PR #3674: URL: https://github.com/apache/calcite/pull/3674#issuecomment-1943144254
> The title says something should not be used, but there is no test to tell me that the claim of the JIRA case is true or has been fixed by this PR. In the current code base, `mq.getRowCount` is used in most cases inside `computeSelfCost`. On the other hand, `estimatedRowCount` is only used in some rare cases, which are fixed by this PR. As @rubenada already pointed out, there is also a javadoc, which states that the claim of the JIRA case is true. In my point of view, there is no need to prove this by a unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
