julianhyde commented on code in PR #3677: URL: https://github.com/apache/calcite/pull/3677#discussion_r1501127168
########## core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java: ########## @@ -647,58 +541,225 @@ private static Expression checkExpressionPadTruncate( } } + private Expression translateCastToDate(RelDataType sourceType, + Expression operand, ConstantExpression format, + Supplier<Expression> defaultExpression) { + + switch (sourceType.getSqlTypeName()) { + case CHAR: + case VARCHAR: + // If format string is supplied, parse formatted string into date + return Expressions.isConstantNull(format) + ? Expressions.call(BuiltInMethod.STRING_TO_DATE.method, operand) + : Expressions.call(Expressions.new_(BuiltInMethod.PARSE_DATE.method.getDeclaringClass()), Review Comment: A few other SQL functions are implemented by non-static methods (generally to allow caching of expensive state). Do whatever those functions do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org