Anthrino commented on code in PR #3677:
URL: https://github.com/apache/calcite/pull/3677#discussion_r1523640558
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java:
##########
@@ -239,6 +245,12 @@ private static RelDataType
createTypeWithNullabilityFromExpr(RelDataTypeFactory
}
return false;
}
+
+ // Validate format argument is string type if included
Review Comment:
Good catch, simplified into single return statement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
