Anthrino commented on code in PR #3677:
URL: https://github.com/apache/calcite/pull/3677#discussion_r1522185271
##########
core/src/main/java/org/apache/calcite/util/format/FormatModels.java:
##########
@@ -142,9 +142,7 @@ MI, literalElement(":"), SS, literalElement(" "),
map.put("%Y", YYYY);
map.put("%y", YY);
map.put("%Z", TZR);
- BIG_QUERY = create(map);
- map.clear();
Review Comment:
That was clearing off all the previous records added to the `FormatElements`
map after creating the `BigQuery` FormatModel (line 145), to add new values and
create the `POSTGRESQL` model (line 177).
All the below format elements used by `POSTGRESQL` are also supposed to be
available in `BigQuery`, so instead of clearing it we can add all those
elements and create both models at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
