caicancai commented on code in PR #3839:
URL: https://github.com/apache/calcite/pull/3839#discussion_r1679548972
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -6965,8 +6965,16 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAlias) {
isWithin(9.0, 0.000001));
f.checkScalarApprox("log(cast(10e-3 as real), 10)", "DOUBLE NOT NULL",
isWithin(-2.0, 0.000001));
+ f.checkScalarApprox("log(10)", "DOUBLE NOT NULL",
+ isWithin(2.302585092994046, 0.000001));
f.checkNull("log(cast(null as real), 10)");
f.checkNull("log(10, cast(null as real))");
+ f.checkFails("log(0)",
+ "Cannot take logarithm of zero or negative number", true);
+ f.checkFails("log(0, 64)",
Review Comment:
In fact, in LOG(numeric1 [, base ]) these two parameters cannot both be 0 or
negative, otherwise errors will be reported in postgres and bigqeury.
I don't think there is a need to display illegal values since neither
postgres nor bigquery display them, and my error messages mainly draw on
bigquery and postgres.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
