caicancai commented on code in PR #3839:
URL: https://github.com/apache/calcite/pull/3839#discussion_r1679564883
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7017,24 +7025,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAlias) {
final Consumer<SqlOperatorFixture> consumer = f -> {
f.checkScalarApprox("log(10, 10)", "DOUBLE",
isWithin(1.0, 0.000001));
- f.checkScalarApprox("log(64, 8)", "DOUBLE",
+ f.checkScalarApprox("log(8, 64)", "DOUBLE",
isWithin(2.0, 0.000001));
- f.checkScalarApprox("log(27,3)", "DOUBLE",
+ f.checkScalarApprox("log(3,27)", "DOUBLE",
isWithin(3.0, 0.000001));
- f.checkScalarApprox("log(100, 10)", "DOUBLE",
- isWithin(2.0, 0.000001));
f.checkScalarApprox("log(10, 100)", "DOUBLE",
+ isWithin(2.0, 0.000001));
+ f.checkScalarApprox("log(100, 10)", "DOUBLE",
isWithin(0.5, 0.000001));
- f.checkScalarApprox("log(cast(10e6 as double), 10)", "DOUBLE",
+ f.checkScalarApprox("log(10, cast(10e6 as double))", "DOUBLE",
Review Comment:
done.
I left out a portion, like 10e8, which I thought would be good for testing
diversity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
