mihaibudiu commented on code in PR #3839:
URL: https://github.com/apache/calcite/pull/3839#discussion_r1681948474
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -4202,67 +4206,65 @@ private static class LogicalNotImplementor extends
AbstractRexCallImplementor {
* appropriate base (i.e. base e for LN).
*/
private static class LogImplementor extends AbstractRexCallImplementor {
- LogImplementor() {
+ private final SqlLibrary library;
+ LogImplementor(SqlLibrary library) {
super("log", NullPolicy.STRICT, true);
+ this.library = library;
}
@Override Expression implementSafe(final RexToLixTranslator translator,
final RexCall call, final List<Expression> argValueList) {
- return Expressions.call(BuiltInMethod.LOG.method, args(call,
argValueList));
- }
-
+ return Expressions.
+ call(BuiltInMethod.LOG.method, args(call, argValueList, library));
+ }
+
+ /**
+ * This method, `args`, is used to handle the arguments for logarithmic
functions in SQL.
Review Comment:
what is "`args`" here?
If you want to document the parameters please use the proper JavaDoc format
using `@parameter` to describe what each parameter does.
This is almost ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
