caicancai commented on code in PR #3874:
URL: https://github.com/apache/calcite/pull/3874#discussion_r1685341278
##########
core/src/main/java/org/apache/calcite/rel/rules/SortJoinCopyRule.java:
##########
@@ -96,9 +96,7 @@ public SortJoinCopyRule(Class<? extends Sort> sortClass,
if (leftFieldCollation.isEmpty()) {
newLeftInput = join.getLeft();
} else {
- final RelCollation leftCollation =
- RelCollationTraitDef.INSTANCE.canonize(
- RelCollations.of(leftFieldCollation));
+ final RelCollation leftCollation = RelCollations.of(leftFieldCollation);
Review Comment:
One question, why did you change it? I observed that you only changed the
shift interface, and the shift interface was not called here because this part
itself is redundant.
I observed that the return value of the of interface is return
RelCollationTraitDef.INSTANCE.canonize(collation), and it seems that this part
of the code is indeed redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
