caicancai commented on code in PR #3874:
URL: https://github.com/apache/calcite/pull/3874#discussion_r1685336405
##########
core/src/main/java/org/apache/calcite/rel/RelCollations.java:
##########
@@ -270,7 +270,7 @@ public static RelCollation shift(RelCollation collation,
int offset) {
for (RelFieldCollation fc : collation.getFieldCollations()) {
fieldCollations.add(fc.shift(offset));
}
- return new RelCollationImpl(fieldCollations.build());
+ return RelCollationTraitDef.INSTANCE.canonize(new
RelCollationImpl(fieldCollations.build()));
Review Comment:
Looks good, maybe some JavaDoc could be added here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
