asolimando commented on code in PR #3874:
URL: https://github.com/apache/calcite/pull/3874#discussion_r1685438425
##########
core/src/main/java/org/apache/calcite/rel/rules/SortJoinCopyRule.java:
##########
@@ -96,9 +96,7 @@ public SortJoinCopyRule(Class<? extends Sort> sortClass,
if (leftFieldCollation.isEmpty()) {
newLeftInput = join.getLeft();
} else {
- final RelCollation leftCollation =
- RelCollationTraitDef.INSTANCE.canonize(
- RelCollations.of(leftFieldCollation));
+ final RelCollation leftCollation = RelCollations.of(leftFieldCollation);
Review Comment:
[RelCollations.of](https://github.com/apache/calcite/pull/3874/files#diff-d50ce55582ce0f63226670b6234a635b70884a7055fce75df03043b4a77f9f62L85)
is already canonizing, only shift needs to be changed to avoid the need of
canonization in the callers (this is explained in details in the Jira ticket),
so it looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
