szucsvillo commented on code in PR #249:
URL: https://github.com/apache/calcite-avatica/pull/249#discussion_r1760597134
##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -233,8 +233,8 @@ private static void setupUsers(File keytabDir) throws
KrbException {
// Passes the GSSCredential into the HTTP client implementation
final AvaticaCommonsHttpClientImpl httpClient =
new AvaticaCommonsHttpClientImpl(httpServerUrl);
- httpClient.setGSSCredential(credential);
httpClient.setHttpClientPool(pool, config);
+ httpClient.setGSSCredential(credential);
Review Comment:
Inside setHttpClientPool, the initializeClient method is called, which
initializes the persistentContext object. After that setGSSCredential method
sets the credentials within persistentContext.
If we try to set the credentials before initializing persistentContext, it
would result in a NullPointerException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
