szucsvillo commented on code in PR #249:
URL: https://github.com/apache/calcite-avatica/pull/249#discussion_r1765074077
##########
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java:
##########
@@ -109,34 +110,33 @@ protected void
initializeClient(PoolingHttpClientConnectionManager pool,
HttpClientBuilder httpClientBuilder =
HttpClients.custom().setConnectionManager(pool)
.setDefaultRequestConfig(requestConfig);
this.client = httpClientBuilder.build();
+
Review Comment:
I have tried setting these directly on the client object, but I think it
would require quite a lot of refactoring. For example, practically the whole
AvaticaHttpClientFactoryImpl class should be rewritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
