stoty commented on code in PR #249:
URL: https://github.com/apache/calcite-avatica/pull/249#discussion_r1765114833
##########
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java:
##########
@@ -109,34 +110,33 @@ protected void
initializeClient(PoolingHttpClientConnectionManager pool,
HttpClientBuilder httpClientBuilder =
HttpClients.custom().setConnectionManager(pool)
.setDefaultRequestConfig(requestConfig);
this.client = httpClientBuilder.build();
+
Review Comment:
Good point.
Maybe in a followup ticket.
##########
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java:
##########
@@ -91,6 +91,7 @@ public class AvaticaCommonsHttpClientImpl implements
AvaticaHttpClient, HttpClie
protected CredentialsProvider credentialsProvider = null;
protected Lookup<AuthSchemeFactory> authRegistry = null;
protected Object userToken;
+ protected HttpClientContext persistentContext;
Review Comment:
I think we can call this simply context or HttpContext.
Persistence should be implied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
