stoty commented on code in PR #3971:
URL: https://github.com/apache/calcite/pull/3971#discussion_r1776430059
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java:
##########
@@ -117,7 +117,7 @@ static QueryBuilder analyze(RexNode expression) throws
ExpressionNotAnalyzableEx
}
return e != null ? e.builder() : null;
} catch (Throwable e) {
- Throwables.propagateIfPossible(e, UnsupportedOperationException.class);
+ Throwables.throwIfInstanceOf(e, UnsupportedOperationException.class);
Review Comment:
According to the Javadoc, throwIfInstanceOf is not a 1:1 replacement for
propagateIfPossible.
The old code would throw other RunTime exceptions directly, while the new
one wraps them.
This may be a good thing, but the commit message wording does not suggest
behavioural changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
