julianhyde commented on code in PR #3971:
URL: https://github.com/apache/calcite/pull/3971#discussion_r1807959046
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java:
##########
@@ -117,7 +117,7 @@ static QueryBuilder analyze(RexNode expression) throws
ExpressionNotAnalyzableEx
}
return e != null ? e.builder() : null;
} catch (Throwable e) {
- Throwables.propagateIfPossible(e, UnsupportedOperationException.class);
+ Throwables.throwIfInstanceOf(e, UnsupportedOperationException.class);
Review Comment:
I wasn't aware that the methods have different behavior. Thanks for bringing
it to my attention.
However, there is no obligation to document behavioral changes that occur in
'behavior is unspecified' territory.
This block - like pretty much every `catch (Throwable)` block - is in that
territory, and I didn't think too much about which use cases would be affected
because - by definition - there are no documented, tested use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
