NobiGo commented on PR #3975: URL: https://github.com/apache/calcite/pull/3975#issuecomment-2376418908
> I see that you are performing the changes that we discuss here in another pull request (#3981). This is a bit confusing and I am losing track on where I should comment on. These are two different questions. So I open another PR for VALUES. But we can talk about it together here. These are some of my opinions： For Values: values(1, 2, 3, null), (1, 2, null, null), (5, 2, 3, null) We pull up the predicate is [=($1, 2), IS NULL($3)]. Do we need to extract [OR(IS NULL($2), =($2, 3))]? I think we don't need it. Because when VALUES size is large, It will be complicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
