NobiGo commented on PR #3975: URL: https://github.com/apache/calcite/pull/3975#issuecomment-2423243687
@zabetak As the unit test, We always extract the predicate `IS NULL($1)` when `null` or `comm = null` so the `RexUnknownAs` will not affect the results. And I have discovered another logic that can be optimized: `select comm = 2 from emp where comm = 2` can pull up `=($0, true)` `select comm = 3 from emp where comm = 2` can pull up `=($0, false)` `select comm = 2 from emp where comm = 2 and empno = 1` can pull up `=($0, true)` `select comm = 2 empno = 1 and from emp where comm = 2 and empno = 1` can pull up `=($0, true)` Now the pull up predicate is nothing. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
