NobiGo commented on code in PR #3975: URL: https://github.com/apache/calcite/pull/3975#discussion_r1777215328
########## core/src/test/java/org/apache/calcite/test/RelMetadataTest.java: ########## @@ -2593,6 +2593,79 @@ private void checkPredicates(RelOptCluster cluster, RelOptTable empTable, } + /** Test case for + * <a href="https://issues.apache.org/jira/browse/CALCITE-6592";>[CALCITE-6592] + * RelMdPredicates pull up wrong predicate from UNION when it's input include NULL VALUE</a>. */ + @Test void testPullUpPredicatesFromUnionWithValues1() { + final String sql = "select cast(null as integer) as a\n" + + "union all\n" + + "select 5 as a"; + final Union rel = (Union) sql(sql).toRel(); + final RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RelOptPredicateList inputSet = mq.getPulledUpPredicates(rel); + ImmutableList<RexNode> pulledUpPredicates = inputSet.pulledUpPredicates; + assertThat(pulledUpPredicates, sortsAs("[OR(null, =($0, 5))]")); + } + + @Test void testPullUpPredicatesFromUnionWithValues2() { + final String sql = "select 6 as a\n" + + "union all\n" + + "select 5 as a"; + final Union rel = (Union) sql(sql).toRel(); + final RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RelOptPredicateList inputSet = mq.getPulledUpPredicates(rel); + ImmutableList<RexNode> pulledUpPredicates = inputSet.pulledUpPredicates; + assertThat(pulledUpPredicates, sortsAs("[SEARCH($0, Sarg[5, 6])]")); + } + + @Test void testPullUpPredicatesFromUnionWithValues3() { + final String sql = "select cast(null as integer) as a, cast(null as integer) as b, 7 as c\n" + + "union all\n" + + "select 5 as a, 6 as b, 7 as c"; + final Union rel = (Union) sql(sql).toRel(); + final RelMetadataQuery mq = rel.getCluster().getMetadataQuery(); + RelOptPredicateList inputSet = mq.getPulledUpPredicates(rel); + ImmutableList<RexNode> pulledUpPredicates = inputSet.pulledUpPredicates; + assertThat(pulledUpPredicates, sortsAs("[=($2, 7), OR(null, AND(=($0, 5), =($1, 6)))]")); + } + + @Test void testPullUpPredicatesFromValues() { + final String sql = "values(1,2,3)"; + final Values values = (Values) sql(sql).toRel(); + final RelMetadataQuery mq = values.getCluster().getMetadataQuery(); + RelOptPredicateList inputSet = mq.getPulledUpPredicates(values); + ImmutableList<RexNode> pulledUpPredicates = inputSet.pulledUpPredicates; + assertThat(pulledUpPredicates, sortsAs("[=($0, 1), =($1, 2), =($2, 3)]")); + } + + @Test void testPullUpPredicatesFromValues2() { + final String sql = "values(null)"; + final Values values = (Values) sql(sql).toRel(); + final RelMetadataQuery mq = values.getCluster().getMetadataQuery(); + RelOptPredicateList inputSet = mq.getPulledUpPredicates(values); + ImmutableList<RexNode> pulledUpPredicates = inputSet.pulledUpPredicates; + assertThat(pulledUpPredicates, sortsAs("[=($0, null)]")); Review Comment: @zabetak @mihaibudiu I noticed we have a method to handle this: 1) If field `i` is equal to a constant expression, then we use `EQUALS` 2) If field `i` is nullable, then we use `IS NOT DISTINCT FROM` 3) If filed `i` is the literal null, then we use `IS NULL` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
