julianhyde commented on code in PR #3984:
URL: https://github.com/apache/calcite/pull/3984#discussion_r1806921395
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -4710,8 +4710,9 @@ protected void validateMustFilterRequirements(SqlSelect
select, SelectNamespace
}
// Remaining must-filter fields can be defused by a bypass-field,
// so we pass this to the consumer.
- Set<SqlQualified> remnantMustFilterFields =
Stream.of(remnantQualifieds, qualifieds)
- .flatMap(Set::stream).collect(Collectors.toSet());
+ ImmutableSet<SqlQualified> remnantMustFilterFields =
+ Stream.of(remnantQualifieds, qualifieds)
+ .flatMap(Set::stream).collect(ImmutableSet.toImmutableSet());
ns.mustFilterRequirements =
new
MustFilterRequirements(ImmutableBitSet.fromBitSet(mustFilterFields),
ImmutableBitSet.fromBitSet(mustFilterBypassFields),
Review Comment:
indent + 4
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -4710,8 +4710,9 @@ protected void validateMustFilterRequirements(SqlSelect
select, SelectNamespace
}
// Remaining must-filter fields can be defused by a bypass-field,
// so we pass this to the consumer.
- Set<SqlQualified> remnantMustFilterFields =
Stream.of(remnantQualifieds, qualifieds)
- .flatMap(Set::stream).collect(Collectors.toSet());
+ ImmutableSet<SqlQualified> remnantMustFilterFields =
+ Stream.of(remnantQualifieds, qualifieds)
+ .flatMap(Set::stream).collect(ImmutableSet.toImmutableSet());
Review Comment:
indent + 4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
