julianhyde commented on PR #3984: URL: https://github.com/apache/calcite/pull/3984#issuecomment-2423120510
Latest commit looks fairly close. There needs to be an cogent explanation in the code for the concepts of bypass fields etc. The javadoc for `class FilterRequirement` seems like a good place. Add a couple of worked examples, like my 'table t has must-filter field f and bypass field b and the query "select ... from t" has ...'. Move the current descriptions of the 3 fields onto the fields themselves. 'Remnant' is not a good name because it forces you to talk about how we got here - the winnowing algorithm - rather than there we are. I prefer 'anyFitlerFields' because for the query to be valid you need to filter any of them. I think you can make `FilterRequirement` immutable if you have a subclass of `SqlVisitor` that has 3 mutable fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
