olivrlee commented on code in PR #3984:
URL: https://github.com/apache/calcite/pull/3984#discussion_r1806968974
##########
core/src/main/java/org/apache/calcite/sql/validate/MustFilterRequirements.java:
##########
@@ -37,9 +35,9 @@ public class MustFilterRequirements {
ImmutableBitSet mustFilterFields;
ImmutableBitSet mustFilterBypassFields;
- protected Set<SqlQualified> remnantMustFilterFields;
+ protected ImmutableSet<SqlQualified> remnantMustFilterFields;
public MustFilterRequirements(ImmutableBitSet mustFilterFields,
- ImmutableBitSet mustFilterBypassFields, Set<SqlQualified>
remnantMustFilterFields) {
+ ImmutableBitSet mustFilterBypassFields, ImmutableSet<SqlQualified>
remnantMustFilterFields) {
Review Comment:
Does this apply to the first two parameters as well?
I see I could use `ImmutableBitSet.fromBitSet()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
