mihaibudiu commented on code in PR #2811:
URL: https://github.com/apache/calcite/pull/2811#discussion_r1809291506
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -290,7 +290,7 @@ public static void checkActualAndReferenceFiles() {
*/
@Test void testAsOfCast() {
final String sql = "SELECT * "
- + "FROM (SELECT deptno % 10 as m, CAST(deptno AS BIGINT) as deptno
FROM dept) D\n"
+ + "FROM (SELECT CAST(deptno % 10 AS BIGINT) as m, CAST(deptno AS
BIGINT) as deptno FROM dept) D\n"
Review Comment:
Maybe this is cause by the recent changes I made to the TypeCoercion which
got merged into main: https://github.com/apache/calcite/pull/3998
In this case this change is fine.
The ASOF join seems a bit brittle. I have followed the spec from Snowflake
for its definition, but I wonder whether we can improve that.
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -290,7 +290,7 @@ public static void checkActualAndReferenceFiles() {
*/
@Test void testAsOfCast() {
final String sql = "SELECT * "
- + "FROM (SELECT deptno % 10 as m, CAST(deptno AS BIGINT) as deptno
FROM dept) D\n"
+ + "FROM (SELECT CAST(deptno % 10 AS BIGINT) as m, CAST(deptno AS
BIGINT) as deptno FROM dept) D\n"
Review Comment:
Maybe this is caused by the recent changes I made to the TypeCoercion which
got merged into main: https://github.com/apache/calcite/pull/3998
In this case this change is fine.
The ASOF join seems a bit brittle. I have followed the spec from Snowflake
for its definition, but I wonder whether we can improve that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
