mihaibudiu commented on code in PR #2811:
URL: https://github.com/apache/calcite/pull/2811#discussion_r1809693068
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -290,7 +290,7 @@ public static void checkActualAndReferenceFiles() {
*/
@Test void testAsOfCast() {
final String sql = "SELECT * "
- + "FROM (SELECT deptno % 10 as m, CAST(deptno AS BIGINT) as deptno
FROM dept) D\n"
+ + "FROM (SELECT CAST(deptno % 10 AS BIGINT) as m, CAST(deptno AS
BIGINT) as deptno FROM dept) D\n"
Review Comment:
Adding the cast is fine for now. The spec for ASOF requires it,
unfortunately.
Today the validator checks the shape of the ASOF join before optimizations.
But optimizations may change it. Ideally it should only be checked after
optimizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
