NobiGo commented on code in PR #2811:
URL: https://github.com/apache/calcite/pull/2811#discussion_r1809692070
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -290,7 +290,7 @@ public static void checkActualAndReferenceFiles() {
*/
@Test void testAsOfCast() {
final String sql = "SELECT * "
- + "FROM (SELECT deptno % 10 as m, CAST(deptno AS BIGINT) as deptno
FROM dept) D\n"
+ + "FROM (SELECT CAST(deptno % 10 AS BIGINT) as m, CAST(deptno AS
BIGINT) as deptno FROM dept) D\n"
Review Comment:
The exception is `ASOF JOIN condition must be a conjunction of equality
comparisons`. The ON condition will converted to `CAST(D.M AS BIGINT) =
E.EMPNO` if we don't change the D.M type.
Before this PR, Integer and BigInt don't need to cast. But now it needs.
Before #3998, we don't need to make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
