caicancai commented on code in PR #4020:
URL: https://github.com/apache/calcite/pull/4020#discussion_r1821000333
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowFieldType.java:
##########
@@ -93,6 +95,10 @@ public static ArrowFieldType of(ArrowType arrowType) {
}
case Date:
return DATE;
+ case Time:
Review Comment:
The following is arrow's explanation of the time type
> Time is either a 32-bit or 64-bit signed integer type representing an
elapsed time since midnight, stored in either of four units: seconds,
milliseconds, microseconds or nanoseconds. The integer `bitWidth` depends on
the `unit` and must be one of the following: * SECOND and MILLISECOND: 32 bits
* MICROSECOND and NANOSECOND: 64 bits The allowed values are between 0
(inclusive) and 86400 (=24*60*60) seconds (exclusive), adjusted for the time
unit (for example, up to 86400000 exclusive for the MILLISECOND unit). This
definition doesn't allow for leap seconds. Time values from measurements with
leap seconds will need to be corrected when ingesting into Arrow (for example
by replacing the value 86400 with 86399).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
