mihaibudiu commented on code in PR #4020:
URL: https://github.com/apache/calcite/pull/4020#discussion_r1821256399
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowFieldType.java:
##########
@@ -93,6 +95,10 @@ public static ArrowFieldType of(ArrowType arrowType) {
}
case Date:
return DATE;
+ case Time:
Review Comment:
this is on the Arrow side, but most SQL types on the Calcite side have a
precision, and some have a scale too. The question is about how the precision
matters when generating arrow. Perhaps you can write at least one test using,
let's say, TIMESTAMP(3) or CHAR(3) as a Calcite type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
