caicancai commented on code in PR #4020:
URL: https://github.com/apache/calcite/pull/4020#discussion_r1823019171


##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowFieldType.java:
##########
@@ -93,6 +95,10 @@ public static ArrowFieldType of(ArrowType arrowType) {
       }
     case Date:
       return DATE;
+    case Time:

Review Comment:
   At present, it seems that the arrow adapter will translate the time type 
uniformly into time(0). This seems to be a bug. I will fix it.
   @mihaibudiu I would like to ask a question about how calcite distinguishes 
the precision of the time type, such as `Second == time(0)`,` MilliSecond == 
time(3)` and so on. I am not very clear about this aspect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to