NobiGo commented on code in PR #4043: URL: https://github.com/apache/calcite/pull/4043#discussion_r1847506377
########## arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowDataTypeConstants.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.adapter.arrow; + +/** + * Constants for Arrow data types. + */ +public interface ArrowDataTypeConstants { + int ARROW_DEFAULT_DECIMAL_PRECISION = 19; Review Comment: Is the decimal precision an ARROW default value or a user-defined variable? As far as I know, when the RelNode is in the Adapter, we should already have a precision and Scale in Decimal Type. ########## arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java: ########## @@ -185,18 +188,24 @@ private static RelDataType deduceRowType(Schema schema, } private static TreeNode makeLiteralNode(String literal, String type) { - switch (type) { - case "integer": + if (type.startsWith("decimal")) { Review Comment: If we have RelDataType, then we can switch by SqlTypeName and get the precision and scale by RelDataType. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
