caicancai commented on code in PR #4043:
URL: https://github.com/apache/calcite/pull/4043#discussion_r1850379163
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -197,6 +200,26 @@ private static TreeNode makeLiteralNode(String literal,
String type) {
case "string":
return TreeBuilder.makeStringLiteral(literal.substring(1,
literal.length() - 1));
default:
+ return makeLiteralNode2(literal, type);
+ }
+ }
+
+ /**
+ * Creates a literal node for a data type with precision.
+ *
+ * @param literal the string representation of the value
+ * @param type the data type, expected to be in the format
"type(precision,scale)"
+ * @return the corresponding TreeNode for the literal
+ */
+ private static TreeNode makeLiteralNode2(
Review Comment:
It may be a problem of personal coding habits. I have unified it in one
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
