mihaibudiu commented on code in PR #4043:
URL: https://github.com/apache/calcite/pull/4043#discussion_r1850846365
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -185,18 +188,24 @@ private static RelDataType deduceRowType(Schema schema,
}
private static TreeNode makeLiteralNode(String literal, String type) {
- switch (type) {
- case "integer":
+ if (type.startsWith("decimal")) {
Review Comment:
this is a private function, why does the parameter have to be a string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
