NobiGo commented on code in PR #4055:
URL: https://github.com/apache/calcite/pull/4055#discussion_r1849612927
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -121,6 +121,10 @@ public StarRocksSqlDialect(Context context) {
return new SqlDataTypeSpec(
new SqlBasicTypeNameSpec(SqlTypeName.BIGINT, SqlParserPos.ZERO),
SqlParserPos.ZERO);
+ case VARCHAR:
Review Comment:
You can try to follow the startRocks behavior. Does Starrocks support
Varchar without setting precision? If so, add test cases to override it. If
not, set the default varchar precision to Starrocks' default value. Also, add
unit test to cover when Varchar setting precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
